[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Let SWIG pickup the INVALID and IGNORED REVNUM constants.

From: <subversion_at_millenix.mailshell.com>
Date: 2004-01-02 02:21:25 CET

Quick note on the patch:
> Index: subversion/include/svn_types.h
> ===================================================================
> --- subversion/include/svn_types.h (revision 8132)
> +++ subversion/include/svn_types.h (working copy)
> @@ -98,14 +98,24 @@
> #define SVN_IS_VALID_REVNUM(n) ((n) >= 0)
>
> /** The 'official' invalid revision num */
> -#define SVN_INVALID_REVNUM ((svn_revnum_t) -1)
> +#define SVN_INVALID_REVNUM_VALUE -1
>
> +/** Macro C code should use for the invalid revision as it handles
> + * typecasting for you.
> + */
> +#define SVN_INVALID_REVNUM ((svn_revnum_t) SVN_IGNORED_REVNUM_VALUE)
                                                   ^^^^^^^^
Shouldn't that be INVALID instead of IGNORED?

> +
> /** Not really invalid...just unimportant -- one day, this can be its
> * own unique value, for now, just make it the same as
> * @c SVN_INVALID_REVNUM.
> */
> -#define SVN_IGNORED_REVNUM ((svn_revnum_t) -1)
> +#define SVN_IGNORED_REVNUM_VALUE -1
>
> +/** Macro C code should use for the ignored revision as it handles
> + * typecasting for you.
> + */
> +#define SVN_IGNORED_REVNUM ((svn_revnum_t) SVN_IGNORED_REVNUM_VALUE)
> +
> /** Convert null-terminated C string @a str to a revision number. */
> #define SVN_STR_TO_REV(str) ((svn_revnum_t) atol(str))

Philip Miller

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jan 2 02:21:24 2004

This is an archived mail posted to the Subversion Dev mailing list.