[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Odd status editor bug (yo, CMike)

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-12-29 19:04:01 CET

On Sun, 2003-12-28 at 12:51, Greg Hudson wrote:
> Well, it uncovered a bug in the status editor. In
> libsvn_wc/status.c:close_directory(), currently at line 1339, the code
> checks to see if the target directory hasn't been handled yet. There
> are a couple of bugs in this code; they are easily fixed (see patch at
> end), but I'm thinking maybe that whole section of code should be
> nuked. If the server never said anything about the target, that's the
> same as if the server never even opened the root, right? So why do
> anything at all?

... because if it doesn't do anything at all, close_edit() won't check
for local status issues on the target.

"Nevermind." (My patch to fix the little bugs is still correct, and
I'll commit it as-is.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 29 19:05:28 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.