[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r8102 - branches/1.0-stabilization

From: <kfogel_at_collab.net>
Date: 2003-12-28 19:15:23 CET

Greg Hudson <ghudson@MIT.EDU> writes:
> >From HACKING:
> The STATUS file is not the place for discussion; use the dev mailing
> list for that, and have the file point to the thread.
> So, a "Notes" entry is something you feel compelled to attach your name
> to, because other people might not agree with it, then it doesn't belong
> there. Send mail to the dev list and include the URL of the mail thread
> instead.

What Greg said. (I did put "Notes" fields on some items, but only to
explain why the change is not to be found on trunk, explain where the
patch is, or to give a bit of history that will help a reader
understand the context behind the change.)

I've taken most notes out in r8111 (including some that I'd originally
put in). Please start mailing list threads instead, and link to the
threads from the STATUS file. Or in some cases, the log message of
the change, or the associated issue, might be a good place for the
information formerly in the note.

Regarding Justin's note on r8021: I just moved it into the
"Justification" line, so that probably doesn't need any further
followup. It now reads:

  * r8021
     'svn revert' performance improvement (timestamp sleep once, not N times)
     Justification: trivial; API change; makes error returns correct priority
      +1: jerenkrantz, rooneg

Regarding the "concept" votes:

I'd like to remove them too, but have left them in while we discuss
it. Here's why I think they're not much help:

Knowing that someone agrees with the concept doesn't add very much
information. It doesn't tell us we can apply the change, because that
requires actual review and a real +1. Sure, it tells us that
so-and-so likes the concept, but then, there are probably others who
feel the same and just didn't bother to say so in the STATUS file (for
example, there was a whole thread about the copyright fixup change).

After all, every committer can read the STATUS file, so if they
*didn't* agree with something, they'd have started a thread about it,
maybe even voted -1 too.

It's much better to keep the STATUS file reduced to bare essentials,
with links to further discussion. That way it's easy to browse. And
people should be following the links -- because no one should be
making their decision about a change based just on the information in
the STATUS file anyway, right?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 28 20:07:11 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.