[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 8081 - trunk/subversion/libsvn_repos

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-12-26 04:06:18 CET

On Thu, 2003-12-25 at 22:01, subversion@millenix.mailshell.com wrote:
> > Factor authz checks down into add_file_or_dir and replace_file_or_dir.
> The authz checks and associated call to absent_file_or_dir() appear in both
> functions.
> This patch factors that out. This is the first real work I've done with the
> subversion code, so if it makes sense to do this, could someone check that I
> got the semantics right? Oh yea, it probably needs a better (shorter)
> function name :-)

I don't think it makes much sense to factor that out, given that doing
so adds more lines of code than it takes away.

Also, a key point of the snippets you factored out is to stop if we
decide to call absent_file_or_dir(). Your factoring misses that.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 26 04:07:22 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.