Another API wart: {finish,abort}_report pools

Neither the reporter interface's finish_report method, nor
svn_repos_finish_report(), take a pool parameter. Similarly for
abort_report.

From a memory management perspective, this is no big deal; you only
call finish_report once for a given report, so it's always okay to use
a remembered pool. But from a consistency perspective, this is bad;
normally, an object only needs to remember the pool it was created
with if it will need to save state during a later operation.

This isn't the most important API change in the world, and I'm tied up
in other things, but if someone agrees with me and wants to write up a
patch and enter it as a 1.0 candidate, I'd certainly vote for it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 25 22:36:40 2003