I'm going to wait until the next pass to review carefully for details,
but you need to document your template parser a bit better, in my
opinion. The meaning of '?' in a template isn't very clear, nor do you
say that '?' in opcodes must correspond to a '?' in template. And I
cannot figure out what a 'Z' in the operands field means.
You might also consider simplifying the matcher interface by punting the
operands parameter, accepting an apr_time_exp_t * parameter instead of
an integer results array, and using the template character to decide
which field to apply the results to. A helper function could map
<apr_time_exp_t *, char> to <apr_int32_t *> to decide what structure
field to operate on, since all of the apr_time_exp_t fields have the
same type. (Except, you'd have to deal with skipping differently.
Hmm.)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 21 18:42:22 2003