Re: PATCH: Stop defining identifiers in APR's name space

On Fri, 2003-12-19 at 19:34, Julian Foad wrote:
> > But also, Greg Stein made an interesting suggestion, quoted in the
> > issue (#1644):

That was me, actually.

> > Regarding svn_sort_hash(), do we want to also rename svn_item_t to
> > match?
>
> Renamed to "svn_sort__item_t" in this patch. (Have not renamed
> "svn_sort_compare_items_as_paths" but it is implicitly private because
> it uses a private type for its arguments. Sure, explicit would be
> better, but another time.)

I prefer the previous iteration of Julian's patch, because:

  * I'm pretty certain APR won't want that function, at least in its
current form.

  * Even if it does get similar functionality, I don't think it's
particularly ugly or onerous to continue supporting this in our API.

  * If we're going to have internal symbol names, they should really
start with svn__, not svn_foo__, I think.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Dec 20 04:30:01 2003