Re: Fix Win32 file handle leak in translate-test.exe?

kfogel@collab.net wrote:

>Branko Čibej <brane@xbc.nu> writes:
>
>
>>All ra_local tests pass on Windows with this patch. I'm testing ra_dav
>>and ra_svn right now. If these tests pass, too (and I don't see any
>>reason why they wouldn't), I'd like to include this patch in 0.35.0. I
>>think the fact that it fixes a test failure is reason enough, and it's
>>also minor enough to be safe.
>>
>>Votes, please?
>>
>>
>
>It hasn't even been committed on trunk yet, has it? (I don't see it.)
>
>Let's have it there, so people can easily review it before voting. I
>know you posted it before, and I'm 99% sure it's the one I'm quoting
>below, but it needs to go on trunk anyway, and once it's there, we
>have a concrete revision to talk about.
>
>
Good point. In the meantime I found (and fixed) a subtle memory usage
bug in my patch, *sigh*. I'll commit to trunk as soon as I've run some
tests.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org