Leaking errors

I am making a patch to fix places where we leak svn_error_t objects, and I have encountered one that I don't know how to handle (and nor, judging by the comment, did the author of the code).

In subversion/mod_dav_svn/update.c (dav_svn__update_report): line 1356:

      serr = svn_fs_check_path(&dst_kind, uc.rev_root, dst_path,
                               resource->pool);
      /* ### what to do with this error? */

Some errors in that function are handled like this (which is 15 lines above it):

  serr = svn_repos_finish_report(rbaton);
  if (serr)
    return dav_svn_convert_err(serr, HTTP_INTERNAL_SERVER_ERROR,
                               "A failure occurred while "
                               "driving the update report editor");

How should failure of svn_fs_check_path be handled here?

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 19 03:36:24 2003