Re: Blame temporary file leak on error

On Fri, Dec 19, 2003 at 01:21:25AM +0100, Erik Huelsmann wrote:
>
> Now that the svn_subst_copy_and_translate issue is all cleared up. I started
> looking for other cases where we don't leak handles, but possibly leak
> (closed) temporary files.
>
> The only case I could find is in subversion/libsvn_client/blame.c which
> leaks a temporary file (on disk) when an error occurs between the start of the
> first loop and function completion.
>

I was planning on cleaning this up when implementing cancellation and
notification callbacks for svn_client_blame; as is, a cancellation would
also cause one or two files to be leaked.

I haven't reviewed your change yet, but I'd like to hold off on comitting
it until I have an idea of how the callbacks will wind up being integrated.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 19 01:42:53 2003