[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: branch 0.35.0: All my "make tests" are ok, how about you? ;-)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-12-17 20:11:03 CET

Erik Huelsmann wrote:

>>Jostein Chr. Andersen wrote:
>>
>>
>>
>>>-Checkout, compile and test the current release branch now!
>>>
>>>
>>>
>>>
>>The Windows tests don't pass. translate-test 14 is failing regularly for
>>me. I've tracked it down to an open file handle that prevents us from
>>removing a file during the test. The handle leak is in
>>svn_subst_copy_and_translate.
>>
>>BTW, this is _not_ the same as the Windows access denied error.
>>
>>Just goes to show, we _must_ close files when we're done with them, like
>>I said.
>>
>>
>
>I disagree with that. We depend on APR to do that for us.
>
Well fine, but pray tell, how do you propose to delete a file on Windows
if its still open? The tests are failing on Windows because of this.

>We don't deallocate our memory when we are done with it either.
>
Files are not memory.

> If we were to free up all files
>and memory ourselves we would not need pool programming. There might be a
>problem with interaction between subversion's use of pools and Windows though.
>This could be either a problem in APR or in Subversion and we need to deal
>with that instead of working around it.
>
>
In this case, it's clearly a bug in the function which promises to close
the files it opened, but does a half-assed job of it.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 17 20:14:39 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.