On Sat, Dec 13, 2003 at 05:27:58PM +0000, Philip Martin wrote:
> John Szakmeister <john@szakmeister.net> writes:
>
> > Index: subversion/libsvn_client/blame.c
> > ===================================================================
> > --- subversion/libsvn_client/blame.c (revision 7978)
> > +++ subversion/libsvn_client/blame.c (working copy)
> > @@ -378,7 +378,9 @@
> >
> > SVN_ERR (ra_lib->get_repos_root (session, &reposURL, pool));
> >
> > - lmb.path = url + strlen (reposURL);
> > + /* Convert path from URI to UTF-8 before placing it in the baton */
> > + lmb.path = svn_path_uri_decode (url + strlen (reposURL), pool);
>
> Hmmm...
>
> My first instinct was "the comment is redundant" since it duplicates
> the documented behaviour of the function. Then I realised that the
> documentation doesn't mention UTF-8, so I started thinking about the
> URL. It's already UTF-8 isn't it? Whether the decoded URL is UTF-8
> depends on what characters are URI encoded in the URL, where do we
> guarantee that the URL contains URI encoded UTF-8?
>
> Next I tried a few things
>
[examples snipped]
The examples you raise certainly warrant further consideration, but
IIUC, you don't disagree with this particular change? It looks fine
to me; I think it should be committed.
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 15 13:12:42 2003