kfogel@collab.net wrote:
> Second iteration, after some comments in IRC from Greg Hudson and Erik
> Huelsmann:
>
> --------------------8-<-------cut-here---------8-<-----------------------
>
> Fix issue #1601: do deltification in core code instead of in
> post-commit hook, but (where possible) deltify after responding to the
> client, to avoid user-visible delays.
>
> Thanks to Greg Hudson, Sander Striker, Mike Pilato, Erik Huelsmann,
> and Ben Collins-Sussman for their help.
>
> * subversion/svnserve/serve.c
> (server_baton_t): New boolean field 'daemon'.
> (serve): Store new 'daemon' argument in baton.
I think there's a problem with this patch, because these are not there
anymore.
> Index: subversion/svnserve/serve.c
> ===================================================================
> --- subversion/svnserve/serve.c (revision 7978)
> +++ subversion/svnserve/serve.c (working copy)
> @@ -547,8 +547,20 @@
> if (!aborted)
> {
> SVN_ERR(trivial_auth_request(conn, pool, b));
> +
> + /* In tunnel mode, deltify before answering the client, because
> + answering may cause the client to terminate the connection
> + and thus kill the server. But otherwise, deltify after
> + answering the client, to avoid user-visible delay. */
> +
> + if (b->tunnel)
> + SVN_ERR(svn_fs_deltify_revision(b->fs, new_rev, pool));
> +
> SVN_ERR(svn_ra_svn_write_tuple(conn, pool, "r(?c)(?c)",
> new_rev, date, author));
> +
> + if (! b->tunnel)
> + SVN_ERR(svn_fs_deltify_revision(b->fs, new_rev, pool));
> }
> return SVN_NO_ERROR;
> }
/Tobias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 12 02:03:41 2003