Philip Martin <philip@codematters.co.uk> writes:
> > + /* It's more interesting if the original callback failed, so let
> > + that dominate. */
> > + if (err1)
> > + return err1;
>
> The return above leaks err2
Thanks! Greg Hudson also spotted this; it's fixed in the second
iteration, which I posted about the same time as you posted this.
> > + err = svn_repos_open(&repos, cdb->repos_path, cdb->pool);
> > + if (err)
> > + {
> > + ap_log_perror(APLOG_MARK, APLOG_ERR, err->apr_err, cdb->pool,
> > + "cleanup_deltify: error opening repository '%s'",
> > + cdb->repos_path);
> > + return APR_SUCCESS;
>
> leaks err
Also spotted by Erik Huelsmann.
> > + }
> > +
> > + err = svn_fs_deltify_revision(svn_repos_fs(repos),
> > + cdb->revision, cdb->pool);
> > + if (err)
> > + {
> > + ap_log_perror(APLOG_MARK, APLOG_ERR, err->apr_err, cdb->pool,
> > + "cleanup_deltify: error deltifying against revision %"
> > + SVN_REVNUM_T_FMT " in repository '%s'",
> > + cdb->revision, cdb->repos_path);
>
> ditto
And ditto.
But thanks. For a change that affects all the RA layers, it makes me
feel better that various eyes have been over it.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 12 00:27:16 2003