epg@tigris.org writes:
> Author: epg
> Date: Mon Dec 8 16:05:50 2003
> New Revision: 7963
>
> Modified:
> trunk/subversion/libsvn_wc/adm_files.c
> Log:
> * subversion/libsvn_wc/adm_files.c
> (init_adm): Create SVN_WC__ADM_EMPTY_FILE (empty-file) group- and
> world-readable. This was needlessly preventing copying another
> user's working copy.
>
>
> Modified: trunk/subversion/libsvn_wc/adm_files.c
> ==============================================================================
> --- trunk/subversion/libsvn_wc/adm_files.c (original)
> +++ trunk/subversion/libsvn_wc/adm_files.c Mon Dec 8 16:05:50 2003
> @@ -1071,7 +1071,9 @@
> efficient than just having one around. It doesn't take up much space
> after all. */
> SVN_ERR (svn_wc__make_adm_thing (adm_access, SVN_WC__ADM_EMPTY_FILE,
> - svn_node_file, APR_UREAD, 0, pool));
> + svn_node_file,
> + APR_UREAD | APR_GREAD | APR_WREAD,
> + 0, pool));
This means that Subversion will now add group/world read access even
when the umask of the process removes it, Subversion is no longer
respecting the process umask. Now the group/world read access is not
really a problem since the file is empty, but ignoring the umask is
wrong in principle. It would be better to create the file using the
default permissions and then use the set read-only function to remove
write access.
(Yes, the old code added owner read access without reference to the
umask, that was also wrong, but I don't suppose umasks that remove
owner read are common.)
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 8 23:54:49 2003