[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7956 - in trunk: . subversion/libsvn_subr

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-12-08 20:47:29 CET

dionisos@tigris.org wrote:
> Author: dionisos
> Date: Mon Dec 8 12:19:26 2003
> New Revision: 7956
> Modified: trunk/HACKING
> + * Please wrap your lines in such a way that the message text (if you
> + supply any) so that the message appears on the start of a new line.

Oops - too many words.

> + Like:
> +
> + svn_error_createf (SVN_ERR_FOO, NULL,
> + "Authorisation failed for '%s'", url);

I don't see the point of making this a formal convention. It often happens naturally, but if an error message is very short, why not put it on the end of the first line; and what if the error message is not a simple constant string but, say, a function call like apr_psprintf(pool, "Format", args) or an expression like (query ? "Query" : "Other") ?

> +2. If you are the *original* creator of an error, you would do
> + something like this:
> +
> + return svn_create_error (SVN_ERR_FOO, NULL,
> + "User not permitted to write file");

Sorry I didn't notice this before, but the function is actually called "svn_error_create". (And the indentation is a bit off, but this is only a "README".)

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 8 20:42:39 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.