[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in mod_dav_svn ? svn:mime-type not respected ?

From: Francois Beausoleil <fbos_at_users.sourceforge.net>
Date: 2003-12-08 17:19:44 CET

I cannot test such a fix. No access to a compiler. Can someone do it
and post back results ?

Thanks,
François

On 07 Dec 2003 10:02:02 -0600, "C. Michael Pilato" <cmpilato@collab.net>
said:
> Philip Martin <philip@codematters.co.uk> writes:
> > Playing with httpd.conf shows that the DefaultType directive controls
> > the content type returned. Stepping through dav_svn_set_headers() I
> > see
> >
> > 1791 if ((mimetype == NULL)
> > 1792 && (resource->type == DAV_RESOURCE_TYPE_VERSION)
> > 1793 && (resource->info->repos_path != NULL))
> > 1794 {
> > 1795 svn_string_t *value;
> > (gdb) p resource->type
> > $1 = DAV_RESOURCE_TYPE_REGULAR
> > (gdb)
> >
> > I know very little about DAV so I cannot say whether REGULAR or
> > VERSION is correct, but lines 1792-1793 were added in r7797.
>
> Hm. It looks like that chunk of code should be accepting both VERSION
> and REGULAR resource types. I've got other patches in progress, and
> no time to test a fix, but I wonder what would happen if that
> conditional became:
>
> if ((mimetype == NULL)
> && ((resource->type == DAV_RESOURCE_TYPE_VERSION)
> || (resource->type == DAV_RESOURCE_TYPE_REGULAR))
> && (resource->info->repos_path != NULL))
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
Developer of Java Gui Builder
http://jgb.sourceforge.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 8 17:20:53 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.