[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: More documentation for errors and error handling

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-12-07 03:34:54 CET

Erik Huelsmann wrote:
> Index: subversion/libsvn_subr/README.errors
> ===================================================================
> --- subversion/libsvn_subr/README.errors (revision 7945)
> +++ subversion/libsvn_subr/README.errors (working copy)
> + When your routine receives an error which it intends to ignore or
> + handle itself, be sure to clean it up using svn_error_clear(). Any
> + time such an error are not cleared constitutes a *memory leak*.

"such an error _is_ not ..."

> + Resources associated with pools are:
> + * Memory
> + * Files

You can't just say "Files". You would have to say which files exactly, and in what way they would be "freed". E.g. "files opened with apr_blah_blah and svn_io_blah_blah will be closed; temporary files opened with svn_whatever will be removed".

Are error messages meant to be composed in UTF-8 (and the error handling mechanism then converts them to local encoding just before printing them)? I think this should be stated somewhere.

Everything else sounds good to me.

- Julian

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 7 03:30:03 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.