[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: PATCH: Convert text appropriately for console output and input

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2003-12-07 00:47:42 CET

> Does this look right?

It does to me. Except for one little thing:

> case svn_wc_notify_failed_revert:
>- printf ("Failed to revert %s -- try updating instead.\n",
>+ printf ("Failed to revert '%s' -- try updating instead.\n",
> break;

I've been trying to replace all '--' with '; ' for consistency (and removing
trailing '.'-s on error messages) like this:

+ printf ("Failed to revert '%s'; try updating instead\n",

If you're looking for something to do: it seems there are a *lot* of
locations where we would need to call svn_path_local_style where we currently are
not. Your code made clear to me that there are cases in which we do, but in the
libs I haven't seen any calls to that function.



+++ GMX - die erste Adresse für Mail, Message, More +++
Neu: Preissenkung für MMS und FreeMMS! http://www.gmx.net
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Dec 7 00:48:16 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.