[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: renaming svn_io_file_printf to svn_io_file_printf_from_utf8

From: Sander Striker <striker_at_apache.org>
Date: 2003-12-05 10:59:20 CET

On Fri, 2003-12-05 at 00:14, Branko Čibej wrote:
> Erik Huelsmann wrote:
> >In libsvn_diff there are a lot of calls to svn_io_file_printf which
> >translates from utf8 to locale and does a printf to the specified file.
> >
> Which is especially bad when the "file" happens to be the Win32 console
> output, which typically uses a different encoding than the "native".
> Renaming this file won't help. We need a completely different output
> mechanism if we want this code to ever work correctly in the Windows
> command line.
> >Anyone opposed to making this change?
> >
> >
> I'd rather change the libsvn_diff API to accept a svn_stream handle.
> That way GUI clients can use the diff output formatters in libsvn_diff, too.

You mean the svn_diff_file_output_unified and svn_diff_file_output_merge
APIs? I don't see why not. I'll incorporate this change somewhere at
the end of the day.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 5 11:00:03 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.