[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

renaming svn_io_file_printf to svn_io_file_printf_from_utf8

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2003-12-05 00:04:59 CET

In libsvn_diff there are a lot of calls to svn_io_file_printf which
translates from utf8 to locale and does a printf to the specified file. Conforming to
the convention in svn_utf8_*, I would like to rename the function to
svn_io_file_printf_from_utf8. After doing so, I can then implement a 'true' wrapper
function which does raw printf on the data passed. The wrapper would be
around apr_file_printf just as the recent wrappers I implemented in the
svn_io_file_* range of function names. Calls in libsvn_diff which now call
apr_file_printf could then be replaced by calls to svn_io_file_printf. That way a ###
comment can be eliminated and the (currently discarded) return values can be
wrapped in SVN_ERR.

Basically there is nothing different in the above proposal then I have been
doing all along, except for the fact that I now want to change a function's
name. Until now I only changed function's return value types.

Anyone opposed to making this change?



PS: I could make the patch and submit it for review if the above is

+++ GMX - die erste Adresse für Mail, Message, More +++
Neu: Preissenkung für MMS und FreeMMS! http://www.gmx.net
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Dec 5 00:05:41 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.