[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7922 - in trunk/subversion: libsvn_subr libsvn_wc

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2003-12-03 20:49:26 CET

> On Wed, 2003-12-03 at 13:47, dionisos@tigris.org wrote:
> > err = svn_io_file_read_full (infile, buf, sizeof(buf), &bytes_read,
> pool);
> > if (err && !APR_STATUS_IS_EOF(err->apr_err))
> > return err;
> > - svn_error_clear (err);
> >
> > SVN_ERR_W (svn_xml_parse (svn_parser, buf, bytes_read,
> > err && APR_STATUS_IS_EOF(err->apr_err)),
>
> Well, this svn_error_clear() was certainly incorrect, because it's
> invalid to reference err->apr_err after clearing an error. But it
> doesn't look superfluous; it looks like you need to clear the error
> after the loop finishes.

Hmm, which I'm sure I *did*. Well, guess I have to repair that. Sorry.

bye,

Erik.

-- 
+++ GMX - die erste Adresse für Mail, Message, More +++
Neu: Preissenkung für MMS und FreeMMS! http://www.gmx.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 3 20:50:08 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.