[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Extreme pickyness or just subversion coding standards?

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-12-03 00:45:23 CET

Erik Huelsmann wrote:
> The following patch is ready to be committed. Is it extreme pickyness (and
> overkill) or is this what is to be expected by our coding standards?

As your mailer is wrapping lines of the patch it might be better if you sent the patch as an attachment rather than in line. Or set your mailer's wrapping width to something more than 80 columns.

I've only just seen this patch and have not reviewed it.

[committed 2 hours 20 minutes later]

I find that you generally need to wait at least 24 hours for a review, because people are all over the world and some can only read this while they are at work, some only while they are at home, etc.

Maybe somebody did say it was OK, and I haven't seen the message yet. Or maybe you decided it was safe enough ... I'm not saying it's not OK.

- Julian

> Log:
> [[[
> Extreme pickyness?
> * subversion/libsvn_subr/hash.c (svn_hash_write):
> Eliminate allocation of fixed array on the stack.
> Use apr_psprintf instead of stdio's sprintf.
> Use iteration pool as required by pool conventions
> ]]]

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 3 00:41:30 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.