[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Extreme pickyness or just subversion coding standards?

From: John Szakmeister <john_at_szakmeister.net>
Date: 2003-12-03 00:31:42 CET

On Tuesday 02 December 2003 15:12, Erik Huelsmann wrote:
> The following patch is ready to be committed. Is it extreme pickyness (and
> overkill) or is this what is to be expected by our coding standards?
> bye,
> Erik.
> Log:
> [[[
> Extreme pickyness?

No way. :-) Something I've come to understand and respect the developer's for
is their extreme consistency and diligence on keeping everything looking the
same. Having worked on projects that were not as stringent, I can honestly
say that it has helped me to get more involved, and to get a better feel for
what's going on, rather than wasting time trying to move past everyone's
individual coding convention.

> [snip]
> - SVN_ERR (svn_io_file_write_full (destfile, "K ", 2, NULL, pool));
> + buf = apr_psprintf (iterpool, "%" APR_SSIZE_T_FMT, keylen);
> + SVN_ERR (svn_io_file_write_full (destfile,
> + buf, strlen (buf), NULL,
> iterpool)); + SVN_ERR (svn_io_file_write_full (destfile, "\n", 1,
> NULL, iterpool));

Do we really want to break this up into two seperate writes? Can we just do
something like similar to what was done before and do the following? It
seems like such a waste to write out twice, especially for one byte.

  buf = apr_psprintf (iterpool, "%" APR_SSIZE_T_FMT "\n", keylen)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 3 00:27:26 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.