Re: svn commit: rev 7905 - trunk/subversion/libsvn_client

On Tuesday 02 December 2003 15:32, Philip Martin wrote:
[snip]
> > + SVN_ERR (svn_io_get_dirents (&dirents, path, pool));
> > +
> > + for (hi = apr_hash_first (pool, dirents);
> > + hi;
> > + svn_pool_clear (subpool), hi = apr_hash_next (hi))
>
> I'd classify that as gratuitous use of the comma operator :)
>
> Looking at the old code I see that it is using the subpool in
> svn_io_dir_read, which probably explains why the comma got used
> originally. Your code doesn't need it. Do people like this use of
> the comma operator?

I personally don't like it. I'd rather the 'for' just be related to advancing
and checking the iterator itself. But, as long as we're consistent I don't
mind.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 3 00:16:37 2003