[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Unknown svn_fs_close_txn in example

From: Juanma Barranquero <jmbarranquero_at_wke.es>
Date: 2003-12-02 16:20:45 CET

AFAICS, there's no fs.close_txn (nor svn_fs_close_txn in svn_fs.h), so
this call to it in tools/examples/svnlook.py is bogus.

As the docs state that destroying the pool is enough to close the
transaction, I'd say the try/finally block is not needed anymore.


Index: tools/examples/svnlook.py
--- tools/examples/svnlook.py (revision 7900)
+++ tools/examples/svnlook.py (working copy)
@@ -38,11 +38,7 @@
         rev = fs.youngest_rev(self.fs_ptr, pool)
     self.rev = rev
- try:
- getattr(self, 'cmd_' + cmd)()
- finally:
- if self.txn_ptr:
- fs.close_txn(self.txn_ptr)
+ getattr(self, 'cmd_' + cmd)()
   def cmd_default(self):

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 2 17:02:33 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.