Re: [PATCH] extend svn_io_file_* with calls for read(_full) and write(_full)

On Sun, Nov 30, 2003 at 11:42:03AM -0500, Greg Hudson wrote:
> On Sun, 2003-11-30 at 04:08, Erik Huelsmann wrote:
> > I was about to commit this change when Greg Hudson said he would not have
> > coded it this way, so I'm submitting for review.
>
> Er, I think what Erik meant is: he wrote something, I said it didn't
> look right to me, we talked about it and came up with something new, but
> based on that he wants review on the finished product.
>
> Three comments:
>
> > +/** Wrapper for @c apr_file_read(), which see. */
>
> I guess by "which see," you mean, "see the documentation for that
> function," but I don't think that's very clear.
>

There are a bunch of comments like this running around. I agree, though,
that this construction seems a bit awkward, especially since Doxygen will
make the reference into a link.

--ben

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 1 18:04:24 2003