Re: svn commit: rev 7879 - trunk/doc/book/book

On Sunday 30 November 2003 23.31, Branko Čibej wrote:

> >Log:
> >* doc/book/book/ch05.xml (svn-ch-5-sect-3.4-ex-1):
> > Do a decent attempt at making the sample Perl script for making
> > incremental backups good quality Perl, use Subversion bracket
> > coding standard,
>
> Ouch. If we write Perl examples, I suggest using Perl's recommended
> conding standards. I think this is the first Perl script I've seen
> that uses the GNU brace indentation convention.

Then you should look here:
  packages/win32-innosetup/tools/*.pl :-)

Blair are declaring variables, are using "use strict", using a strict
syntax and have a clean style. This is good!

It's probably no such thing as "Perl's recommended coding standards" but
many Perl programmers like the old Kernighan & Ritchie style:

    if ($foo = 0) {
        do something unredable;
    } elsif ($foo = 1) {
        do something nastier;
    } else {
        make gstein and others port it to python;
    }

The crap above combined with the lack of not declaring variables and
other funny stuff have made many Perl scripts very hard to maintain and
understand.
Many Perl scripts like this have made many experienced programmers to
just turn around and "reinventing" programs. A well known example is
ViewCVS wich was "inspired" of cvsweb - wich is probably done because
the unclean and unmaintable (and somewhat typical) Perl code.

Jostein

-- 
http://www.josander.net/kontakt/ ||
http://www.josander.net/en/contact/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org