[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] extend svn_io_file_* with calls for read(_full) and write(_full)

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-11-30 20:17:19 CET

Greg Hudson wrote:
> On Sun, 2003-11-30 at 04:08, Erik Huelsmann wrote:
>
>>I was about to commit this change when Greg Hudson said he would not have
>>coded it this way, so I'm submitting for review.
>
> Er, I think what Erik meant is: he wrote something, I said it didn't
> look right to me, we talked about it and came up with something new, but
> based on that he wants review on the finished product.
>
> Three comments:
>
>>+/** Wrapper for @c apr_file_read(), which see. */
>
> I guess by "which see," you mean, "see the documentation for that
> function," but I don't think that's very clear.

I think Eric was just copying this from all the existing functions which somebody else wrote. I do vaguely recall someone on the mailing list a few months ago having trouble understanding this construct, so maybe we should change the wording in every case, but not just within Erik's new functions.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 30 20:14:55 2003

This is an archived mail posted to the Subversion Dev mailing list.