[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Problem in copy_versioned_files()?

From: John Szakmeister <john_at_szakmeister.net>
Date: 2003-11-30 01:44:14 CET

I was looking through export.c a little more, hoping that I could factor some
stuff together and fix Issue 1361 in the process.

I see the following happen in copy_versioned_files():

  SVN_ERR (svn_wc_adm_probe_open (&adm_access, NULL, from, FALSE,
                                  FALSE, pool));
  err = svn_wc_entry (&entry, from, adm_access, FALSE, subpool);
  SVN_ERR (svn_wc_adm_close (adm_access));
  if (err)
    {
      if (err->apr_err != SVN_ERR_WC_NOT_DIRECTORY)
        return err;
      else
        svn_error_clear (err);
    }

and then once we determine there is a file to copy, this occurs:

  err = svn_wc_entry (&entry, copy_from, adm_access, FALSE,
                      subpool);

Is this safe? According to svn_wc_adm_close's docstring, "Any physical locks
will be removed from the working copy. Lock removal is unconditional, there
is no check to determine if cleanup is required." This sounds to me like we
shouldn't be accessing the entry information after we've closed the WC.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 30 01:40:20 2003

This is an archived mail posted to the Subversion Dev mailing list.