Re: [PATCH] Better handling of wrong passwords or no passwords for client certificates.

Ben Reser <ben@reser.org> writes:

> * subversion/libsvn_ra_dav/session.c
> (client_ssl_callback): Check return value of ne_ssl_clicert_decrypt.
> If the wrong password is given to decrypt then ne_ssl_set_clicert will
> segfault.

Thanks! See r7872, I also made some other changes to tidy up the
code.

Questions (not specifically for Ben)
- do we need to notify the user if the decrypt fails?
- any reason this file uses apr_pool_create/destroy rather than
  svn_pool_create/destroy?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org