Re: [PATCH] svn_fs_text_changed

"C. Michael Pilato" <cmpilato@collab.net> writes:

> It's not the output that I'm concerned with. It's the extra work
> happening under the hood. If you still have your test scenario above,
> set a breakpoint on repos_diff.c:window_handler. If you even once see
> a non-NULL window, Subversion is being inefficient. And that's what I
> was seeing.

Okay, my original report did contain some misdiagnosis. I forgot that
a URL-to-URL diff was:

   1. Get the fulltext of tree 1.
   2. Get the delta from tree 1 to tree 2, applied to tree 1 to
       produce tree 2.
   3. Contextually diff tree 1 vs. tree 2.

So, the reason I saw fulltexts fly by was because of step 1, not step
2. Excellent, no extra textual data going over the wire. Whew.

And as for the rest of my concerns -- temporary mental breakdown. I
suffered a complete shutdown of the part of my head that knows how
textdeltas work. I think my systems are all back online now (at
least, the aforementioned ones anyway).

Apologies for unnecessary list chatter.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 26 04:32:18 2003