Re: svn commit: rev 7814 - in trunk/subversion: libsvn_fs libsvn_fs/util mod_dav_svn tests/libsvn_fs

C. Michael Pilato wrote:

>Philip Martin <philip@codematters.co.uk> writes:
>
>
>
>>>+ err = svn_fs_abort_txn (txn4, pool);
>>>+ if (! err)
>>>+ return svn_error_create
>>>+ (SVN_ERR_FS_GENERAL, NULL,
>>>+ "expected error trying to abort a committed txn; got none");
>>>+ else if (err->apr_err != SVN_ERR_FS_TRANSACTION_NOT_MUTABLE)
>>>+ return svn_error_create
>>>+ (SVN_ERR_FS_GENERAL, NULL,
>>>+ "got an unexpected error trying to abort a committed txn");
>>>+ }
>>> return SVN_NO_ERROR;
>>>
>>>
>>All three return paths fail to clear or return err.
>>
>>
>
>Well, that just goes to show -- coding while watching the extended
>edition of The Two Towers just doesn't pay off. :-(
>
>Will fix...
>
>
While you're there, wrap 'err' in the second SVN_FS_GENERAL, so that
testers will know _which_ unexpected error you got.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org