python bindings, in abscence of diff ...

Hi!

fs.FileDiff calls an external diff where comparing revisions.
It does so by mean of popen2.popen2(...) I would suggest to
change that to os.popen3(...) and analizing that if there is
"something" in stderr, throw an exception with that content.

The rationale of this is based on the fact that in abscence
of a diff program (or when diff is not in PATH) the output
of FileDiff is an empty string.
Besides there are several diff program out there many of
them differs in their parameters options.
Those problems are difficult to solve because its sympthom
is just a "revisions are equal" output.

BTW, I found this by debugging ViewCVS. I thought that given
that ViewCVS doesn't care of working/local copies it wouldn't
use an external diff program. I was wrong. Is there any
python API to get diff of commited revisions from the
server _directly_?

Regards,
-Hernan

________________________________________________________________________________________
Este mensaje ha sido analizado y protegido por la tecnologia antivirus www.trendmicro.es

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 19 16:26:57 2003