[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] : issue #1584 : Prevent revision props on files/dirs

From: Martin Furter <mf_at_rola.ch>
Date: 2003-11-18 21:35:42 CET

On Tue, 18 Nov 2003, David Kimdon wrote:

> Index: subversion/include/svn_props.h
> ===================================================================
> --- subversion/include/svn_props.h (revision 7781)
> +++ subversion/include/svn_props.h (working copy)
> @@ -276,6 +276,14 @@
> */
> #define SVN_PROP_REVISION_ORIG_DATE SVN_PROP_PREFIX "original-date"
>
> +/*
> + * This is a list of all revision properties.
> + */
> +#define SVN_PROP_REVISION_ALL_PROPS SVN_PROP_REVISION_AUTHOR, \
> + SVN_PROP_REVISION_LOG, \
> + SVN_PROP_REVISION_DATE, \
> + SVN_PROP_REVISION_ORIG_DATE,

I'd say remove the last comma ...

> Index: subversion/libsvn_client/prop_commands.c
> ===================================================================
> --- subversion/libsvn_client/prop_commands.c (revision 7781)
> +++ subversion/libsvn_client/prop_commands.c (working copy)
> @@ -57,6 +57,29 @@
> }
>
>
> + const char *revision_props[] =
> + {
> + SVN_PROP_REVISION_ALL_PROPS
> + NULL,
> + };

... and add it here after SVN_PROP_REVISION_ALL_PROPS.

Perhaps a little bikesheddy, but i think the revision_props[] looks more
C-like when there's comma.

Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 18 21:37:39 2003

This is an archived mail posted to the Subversion Dev mailing list.