RE: URL's in commit mails?
From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2003-11-17 20:33:21 CET
This is actually pretty much exactly what I was thinking of.
-- ~~~~~~~~~~~~~~~~~~~~ Kevin Pilch-Bisson ~~~~~~~~~~~~~~~~~~~~ > -----Original Message----- > From: Julian Foad [mailto:firstname.lastname@example.org] > Sent: Monday, November 17, 2003 11:19 AM > To: C. Michael Pilato > Cc: Kevin Pilch-Bisson; email@example.com; firstname.lastname@example.org > Subject: Re: URL's in commit mails? > > C. Michael Pilato wrote: > > Julian Foad <email@example.com> writes: > > > >>C. Michael Pilato wrote: > >> > >>>There is no information that I aware of which could be used by the > >>>mailer to determine the right schema. Further, only the http:// and > >>>https:// URLs are "browsable" -- you can't fire up Mozilla and expect > >>>to see the right stuff at file:// or svn:// URLs. > >>>So, mailer.py would be limited probably to either display some URL as > >>>defined statically in mailer.conf (which is keyed on the basename of > >>>the repository, I think), or displaying nothing at all. > >> > >>Sure - it can't work automatically for every situation. Perhaps we just > want (first) something that works for firstname.lastname@example.org. > >> > >>For each of the paths listed at the top of the mail as "Added" or > "Modified" it could prepend a statically-configured prefix: default "", > but for us "http://svn.collab.net/repos/svn/". This would give: > >> > >>Modified: > >> http://svn.collab.net/repos/svn/trunk/subversion/include/svn_error.h > >> http://svn.collab.net/repos/svn/trunk/subversion/svnversion/main.c > > > > Please, no. Two reasons: > > > > 1. You're dangerously close to exceeding 80 characters, and those > > paths aren't *nearly* the deepest in our tree. > > 2. You just prepended half a line of info that is redundant across > > the set of all such lines. > > I agree. > > > If we're really going to go this route, then folks, it's time to break > > out the MIME dual HTML/plaintext mail generation code. > > Yes, but that's probably too complex for a quick fix. I think all the > original poster wanted was some quick way of getting from the commit mail > to the repository, so I preferred my second idea of a link to a ViewCVS > server for it ... but that probably doesn't exist in the required form, so > ... > > ... just put a single additional URL at the top, formed from > "http://svn.collab.net/repos/svn/" plus the common parent path that is > already generated for use in the Subject line. > > Or whatever. > > - Julian > > --------------------------------------------------------------------- To unsubscribe, e-mail: email@example.com For additional commands, e-mail: firstname.lastname@example.orgReceived on Mon Nov 17 20:35:20 2003
This is an archived mail posted to the Subversion Dev mailing list.