[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: URL's in commit mails?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2003-11-17 19:32:37 CET

Julian Foad <julianfoad@btopenworld.com> writes:

> C. Michael Pilato wrote:
> > "Kevin Pilch-Bisson" <kevin@pilch-bisson.net> writes:
> >
> >>Sorry, I forgot to mention that this would be something that would have
> >>to be configured, probably keyed off the ${REPOS} which is already
> >>passed to the post-commit script.
> > There is no information that I aware of which could be used by the
> > mailer to determine the right schema. Further, only the http:// and
> > https:// URLs are "browsable" -- you can't fire up Mozilla and expect
> > to see the right stuff at file:// or svn:// URLs.
> > So, mailer.py would be limited probably to either display some URL as
> > defined statically in mailer.conf (which is keyed on the basename of
> > the repository, I think), or displaying nothing at all.
>
> Sure - it can't work automatically for every situation. Perhaps we just want (first) something that works for svn@subversion.tigris.org.
>
> For each of the paths listed at the top of the mail as "Added" or "Modified" it could prepend a statically-configured prefix: default "", but for us "http://svn.collab.net/repos/svn/". This would give:
>
> Modified:
> http://svn.collab.net/repos/svn/trunk/subversion/include/svn_error.h
> http://svn.collab.net/repos/svn/trunk/subversion/svnversion/main.c

Please, no. Two reasons:

  1. You're dangerously close to exceeding 80 characters, and those
      paths aren't *nearly* the deepest in our tree.
  2. You just prepended half a line of info that is redundant across
      the set of all such lines.

If we're really going to go this route, then folks, it's time to break
out the MIME dual HTML/plaintext mail generation code. You can make
short paths be links to long URLs, etc. Pretty graphics. I'm talking
Java FS history node graphs. Flash animations, blinking text, CSS,
DHTML, and ROTFL ...

If you don't stop me, I'll be forced to stop myself.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 17 19:33:57 2003

This is an archived mail posted to the Subversion Dev mailing list.