Julian Foad wrote:
> Ben Collins-Sussman wrote:
>
>> On Sat, 2003-11-15 at 18:26, julianfoad@tigris.org wrote:
>>
>>> * subversion/tests/clients/cmdline/svntest/actions.py
>>> (guarantee_greek_repository): Import the greek tree because that is
>>> faster
>>> than dumping and loading it.
>>
>>
>> Did you ask anyone about this? Maybe I missed the thread.
>
>
> No, I didn't.
>
>> We used to do this, but deliberately stopped doing it for some reason
>> that I can't recall. At a minimum, it's an exercise of 'svnadmin
>> dump/load', which has no regression tests of its own. But I think there
>> was another reason as well.
>
>
> I guessed there was a good reason for doing it, and guessed that that
> was because dump+load used to be faster than import, and that the
> recent performance work had reversed the situation. Now I think about
> it, it might turn out to be slower than dump+load over RA-DAV; I
> didn't test that.
>
> I didn't think of it being of use as a test in itself.
>
> Perhaps we could let it be exercised for a day or so and then I will
> revert it if people think it is overall not a good thing.
It's not a good thing, period. The repository loader only depends on the
dumpfile parser (which is pretty simple and stable) and libsvn_fs, which
has its own exhaustive tests. "svn import", on the other hand, depends
on all the libraries. Therefore, using "svnadmin load" to prepare the
initial tree give us much better confidence that the tests start in a
consistent state than using "svn import".
Please revert this change. And next time, do discuss such things on the
list first.
--
Brane Čibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 16 20:06:53 2003