[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7770 - trunk/subversion/tests/clients/cmdline/svntest

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-11-16 13:56:22 CET

Ben Collins-Sussman wrote:
> On Sat, 2003-11-15 at 18:26, julianfoad@tigris.org wrote:
>
>>* subversion/tests/clients/cmdline/svntest/actions.py
>> (guarantee_greek_repository): Import the greek tree because that is faster
>> than dumping and loading it.
[...]
> We used to do this, but deliberately stopped doing it for some reason
> that I can't recall. At a minimum, it's an exercise of 'svnadmin
> dump/load', which has no regression tests of its own. But I think there
> was another reason as well.

It appears that what we deliberately stopped doing was not this, but something different:

------------------------------------------------------------------------
r4147 | philip | 2002-12-17 21:13:54 +0000 (Tue, 17 Dec 2002) | 13 lines

Use a dump/load cycle to copy repositories intead of an OS filesystem
copy, as the latter does not guarantee a valid repository. This allows
the regression tests to run reliably over ra_svn, but it does mean that
most of the client tests depend on a working dump/load.

* subversion/tests/clients/cmdline/svntest/main.py (copy_repos): New.

* subversion/tests/clients/cmdline/externals_tests.py
  (externals_test_setup): Use copy_repos.

* subversion/tests/clients/cmdline/svntest/actions.py
  (guarantee_greek_repository): Use copy_repos.
------------------------------------------------------------------------

From this I see no reason to suspect a problem with using "import".

"externals_test_setup" still calls copy_repos (and on a slightly more complex repository), so it continues to provide a test of dump and load.

Still, I should have discussed this, and thereby worked through these issues, before committing. Sorry. If there are any more problems with it, perhaps over RA-DAV, just shout at me, or revert it if I am not listening (since I am often out of contact for days at a time).

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 16 14:13:45 2003

This is an archived mail posted to the Subversion Dev mailing list.