[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 7707 - branches/issue-1429-dev/subversion/mod_dav_svn

From: <kfogel_at_collab.net>
Date: 2003-11-12 06:21:53 CET

Greg Stein <gstein@lyra.org> writes:
> Urk. You're making another copy of that string, simply to transform it
> into an svn_string_t structure. Icky. (ooh, and it gets worse...)
>
> Ideally, qval would reside on the stack, and you could:
>
> qval.data = tmp->data;
> qval.len = tmp->len;
>
> Obviously, that will change the other branch, but I imagine you can figure
> out how to do that :-)
>
> Hmm. Now that I pulled up the file to really look at the context, I'd
> recommend changing qval to a 'const char *'. You can then do:
>
> qval = tmp->data;
>
> and in the other branch:
>
> qval = svn_base64_encode_string(value, pool)->data;
>
> Then just write out "qval" rather than "qval->data".

No one will ever notice a difference, but yeah, better karma. Thanks
for the review. *After* getting this branch working, I'll come back
and clean that up.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 12 07:04:12 2003

This is an archived mail posted to the Subversion Dev mailing list.