[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_*: replace remaining apr_file_close

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2003-11-12 01:30:10 CET

Erik Huelsmann wrote:
> The patch below complements the changes from revision 7660. I did not change
> the occurrances of apr_file_close which discard the error code.

I have committed this in r7708 with only a slight change: in three instances I have removed or moved the error variable that is now unused or only used in conditionally-compiled code. E.g.:

subversion/libsvn_subr/io.c: In function `svn_stringbuf_from_file':
subversion/libsvn_subr/io.c:958: warning: unused variable `apr_err'

Thanks.

- Julian

> [[[
> Change the call sequence "apr_file_close, svn_error_create" to
> "SVN_ERR (svn_io_file_close (...))" for brevity and consistency, throughout
> libsvn_*. This complements the changes made in revision 7660.
> ]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 12 01:28:29 2003

This is an archived mail posted to the Subversion Dev mailing list.