Re: [PATCH] svn export needs tests (issue 506)

John Szakmeister <john@szakmeister.net> writes:
> Log:
> ---------------------------------
> A step towards finishing issue #506. Adds a test of an exported greek tree.
>
> * subversion/tests/clients/cmdline/export_tests.py
> (export_greek_tree): New.
> (test_list): Added new export_greek_tree test to the list.
>
> * subversion/tests/clients/cmdline/svntest/actions.py
> (run_and_verify_export): New.

This looks good to me!

One minor question, in the new actions.py:run_and_verify_export():

> + if isinstance(output_tree, wc.State):
> + output_tree = output_tree.old_tree()
> + if isinstance(disk_tree, wc.State):
> + disk_tree = disk_tree.old_tree()
> +
> + # Remove dir if it's already there.
> + main.safe_rmtree(wc_dir_name)

You already remove the target in the caller. Are you sure you want to
remove it here? We might someday have a test that tests what happens
when you export over an existing directory, for example.

I realize that you're probably copying from run_and_verify_checkout(),
which does the same thing, and I have no idea why it does. Especially
since it's doc string doesn't mention the behavior :-).

I read mail on a different machine than my working copy, but will
apply this in the morning.

Thanks!

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 7 06:02:31 2003