Re: [PATCH] libsvn_client: start using svn_io_file_close where applicable

Erik Huelsmann wrote:
> Below I attached a patch for libsvn_client to start using the
> svn_io_file_close where applicable. There is one case in externals.c which discards the
> error output. I did not convert that use to svn_io_file_close, since it would no
> longer be possible to ignore the output.

Lovely. Applied in revision 7660.

> Other libraries will follow in other patches. Also, this patch means that
> the other patch (issue #897) is invalidated. I will resubmit that one as soon
> as we agree on this patch.

OK, thanks. The same change to all the other libraries can be all together in one patch. A big patch is not a problem if it contains only lots of repetitions of the same change.

> [[[
> Change call sequence apr_file_close, svn_error_create to
> SVN_ERR (svn_io_file_close ..).
>
> * subverstion/libsvn_client/blame.c
> * subverstion/libsvn_client/commit.c
> * subverstion/libsvn_client/copy.c
> * subverstion/libsvn_client/diff.c
> * subverstion/libsvn_client/export.c
> * subverstion/libsvn_client/repos_diff.c

"subverstion" -> "subversion" :-)

>
> ]]]

I changed the log message a bit, to indicate briefly _why_ the change is being made, and to omit the list of files, since the same change is made to each file and the list of files is recorded automatically.

[[[
Change the call sequence "apr_file_close, svn_error_create" to
"SVN_ERR (svn_io_file_close (...))" for brevity and consistency, throughout
libsvn_client.
]]]

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 7 01:18:46 2003