[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] issue #897: libsvn_client

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-11-06 08:21:15 CET

On Thu, 2003-11-06 at 02:06, Branko ╚ibej wrote:
> If we know that the message has several "logical" lines (as in the
> checksum mismatch example), then IMHO we should use
> svn_error_quick_wrap.

I strongly disagree. We should not generate a three-level error in
order to present three sequential pieces of information to the user.
svn_error_quick_wrap only makes sense when we want to annotate an error
from a lower-level function with higher-level information.

> Any other kind of wrapping sould have to be done
> by the client, since the client knows best how to display the errors.
> Yes, the cmdline-specific svn_handle_error is in libsvn_subr, but that's
> a special case and GUI clients can do anything they like.

For the command-line client, we should not be wrapping filenames in
error messages, even if they're very long. On the other hand, if we're
in libsvn_client and we want to present a 300-word essay on how to
resolve a commit error, that should be wrapped. But the client has no
idea how to distinguish a filename from a 300-word essay, so it doesn't
know how to wrap.

Fortunately, we do not currently present any 300-word essays, so the
issue is somewhat academic right now. For the specific case of the
checksum error, I think we can shoehorn the information onto one line
without sacrificing clarity; that should allow Erik to put off the issue
now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 6 08:22:02 2003

This is an archived mail posted to the Subversion Dev mailing list.