Re: [PATCH] issue #897: libsvn_client

Hmm, Now that you mention those. I think I should have indeed picked up on
that. I will revise the patch and resubmit when it is ready.

One problem remains: I raised the question on IRC, bug Greg Hudson said it
should not be a problem, since there are no long error messages: the issue
discusses wrapping at 70 columns. We do have long error messages (when filenames
are %s-ed in) and we do have messages with multiple lines. Is it an option
to svn_error_quick_wrap the extra lines into other error structures?

bye,

Erik.

> Erik Huelsmann wrote:
>
> >Hi!
> >
> >My first revision of a patch for libsvn_client cf issue 897.
> >
> >Comments?
> >
> >
> There are a few more things that could be done for consistency.
>
> * Qotes within error messages: '%s' vs. \"%s\". I think we meant to
> standardise on single quotes.
> * Message texts
> o Close-file errors: "Failed to close file '%s'" vs. "Error
> closing file '%s'"
> o Unversioned resource errors: "'%s' is not under version
> control" vs. "'%s' not under version control" vs. "'%s' is
> not versioned". And we seem to be using two different error
> codes for these, SVN_ERR_WC_PATH_NOT_FOUND and
> SVN_ERR_ENTRY_NOT_FOUND
>
> I don't know if fixing these inconsistencies was what you intended.
>
>
> >Index: subversion/libsvn_client/export.c
> >===================================================================
> >--- subversion/libsvn_client/export.c (revision 7644)
> >+++ subversion/libsvn_client/export.c (working copy)
> >@@ -513,7 +513,7 @@
> >
> > apr_err = apr_file_close (fb->tmp_file);
> > if (apr_err)
> >- return svn_error_createf (apr_err, NULL, "error closing file '%s'",
> >+ return svn_error_createf (apr_err, NULL, "Error closing file '%s'",
> > fb->tmppath);
> >
> > if (text_checksum)
> >@@ -525,7 +525,7 @@
> > {
> > return svn_error_createf
> > (SVN_ERR_CHECKSUM_MISMATCH, NULL,
> >- "close_file: checksum mismatch for resulting fulltext\n"
> >+ "Checksum mismatch for resulting fulltext\n"
> > "(%s):\n"
> > " expected checksum: %s\n"
> > " actual checksum: %s\n",
> >
> >
> We shouldn't have multi-line error messages. They may be marginally
> acceptable for the command-line client, but play badly with GUI clients.
> Instead, we should create a chain of (wrapped) errors with the same
> error code, but different message text.
>
>
>
> --
> Brane ÄŒibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

-- 
NEU FÜR ALLE - GMX MediaCenter - für Fotos, Musik, Dateien...
Fotoalbum, File Sharing, MMS, Multimedia-Gruß, GMX FotoService
Jetzt kostenlos anmelden unter http://www.gmx.net
+++ GMX - die erste Adresse für Mail, Message, More! +++
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org