Re: [PATCH] tools/test-script/svntest: test ra_dav also and use conditionally ramdisk

On 2003-11-04 02:14+0100, Branko ??ibej wrote:

> >Index: tools/test-scripts/svntest/svntest.sh
>
> Looks good. The variable checks are especially useful. I'm not too sure
> about the portability of 'test -z', though.

I don't know either, I could change them to '! -n' if this is desirable.

> You've changed most FAILs to 'FAIL umount_ramdisk ...'. Why not just put
> this logic into FAIL?

My master plan is that someday (hopefully not so far away) svntest.sh
could run all layers with static and shared build simultaneously. And this
is the reason to use an argument for FAIL, but...

> After all, umount_ramdisk a) already checks if the
> ramdisk was moutned and b) can extract the parameter from global state.

... indeed this is very true at the moment, so I will go with that
path. (I also feel deep inside of me that current code is somehow a
mess.)

> > # Root of the test tree
> > #
> >-TEST_ROOT="/home/brane/svn"
> >+TEST_ROOT="/data/svntest"
> >
> >
> If you do this, please change the references in README, too.

This slipped inside accidentally. It is echoes of my current setup, as
you could guess.

> I'd suggest using $SVN_NAME here instead of $SVN, and anologously for
> apr, apr-util and httpd.

I will do that. It makes sense, a lot.

> >-BIN="/usr/bin"
> >+BIN="/bin"
> >+USRBIN="/usr/bin"
> > LOCALBIN="/usr/local/bin"
> >+OPTBIN="/opt/bin"
>
> These changes are going to make life a living hell for me if/when I
> migrate them to other OSes; but that's my problem, I guess...

I hope you could bear these changes. =)

> >
> >
> Not if your change to use /data/svntest stays in.

It won't.

> Depends _on_, not depends _of_.
>
> "B is a dependency of A, therefore A depends on B".

In general, if somebody has energy and will to correct my english, I
will be very crateful and I will not feel anyhow offended.

However I understand and confront the fact that this task is like
trying to bring peace on earth or trying to invent a perpetual-motion
machine.

Thanks about the comments!

BR, Jani

-- 
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org