Re: lock:// protocol hacked in

David Kopp wrote:

>Hello,
>
>I have hacked in a lock protocol in my working copy. I added a
>libsvn_ra_lock directory and implemented it as a new RA layer. I choose
>to do this because I thought this functionality is a property of the
>repository location, not of the repository itself.
>
>I don't know a whole lot about patches and stuff, so I just ran svn diff
>and redirected the output into a file.
>
>Without further ado, here is lock.txt
>
>
If I understand your patch correctly, you have a nasty problem waiting
to happen. libsvn_ra_lock and libsvn_ra_local won't live in the same
shared libraries, yet you use non-public methods from ra_local in the
ra_lock implementation. That won't work.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org