Re: broken window checksums?

kfogel@collab.net writes:

> > Should svn_fs__rep_deltify be changed to calculate and save per window
> > (chunk) checksums?
> >
> > Currently there is no code that verifies the per-window checksums.
> > Should rep_undeltify_range() be verifying per-window checksums?
>
> No and no, I think. End-to-end and whole-rep checksums are enough
> protection.

Agreed. We need all the cycles we can get, and if we're using some on
this calculation, that's wasteful. And if we have another schema
change before 1.0 (which is looking likely, I'm sorry to say), we can
core out this unpopulated field.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 3 16:10:03 2003