[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

broken window checksums?

From: David Kimdon <david_at_kimdon.org>
Date: 2003-11-02 13:45:46 CET

Hi,

I see what appears to be an inconsistency between the code and the
documentation.

In subversion/libsvn_fs/structure:288 the svndiff window checksum is
described as the checksum on just the portion of the fulltext
represented by this window. In subversion/libsvn_fs/reps-strings.c
(svn_fs__rep_deltify) around line 1493 the chunk is set to the
checksum of the complete full-text.

Am I missing something?

Do we really want per-window checksums? We already have end-to-end
checksums so maybe per-window checksums are not needed. (update to
issue #1096, the md5sums are not zero anymore, I searched back deep
into revision history and it appears as though they have no been zero
for a while)

Should svn_fs__rep_deltify be changed to calculate and save per window
(chunk) checksums?

Currently there is no code that verifies the per-window checksums.
Should rep_undeltify_range() be verifying per-window checksums?

-David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Nov 2 12:53:30 2003

This is an archived mail posted to the Subversion Dev mailing list.