[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: "svn revert" performance

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-11-01 05:00:06 CET

On Oct 31, 2003, at 8:57 PM, Gareth McCaughan wrote:

>> I'm reviewing your comments, not your patch. Just so you know.
>
> OK. I see Philip has taken a look at the patch and found a few
> horrors... :-)
>
>> Hm... I really don't think we need both svn_client_revert() and
>> svn_client_revert_list(). Just make svn_client_revert() *not* take a
>> const char * path, and start taking an apr_array_header_t * targets
>> list.
>
> Two reasons for not doing it that way:
>
> 1. There may be other things out there using the client
> library. It would be better not to break them.

Too bad for them. This is pre-1.0 code, we reserve the right to change
the APIs if necessary up till 1.0. Having two APIs just seem ugly, and
it's better to change now than to have to live with an ugly interface
for the entire 1.0 lifecycle.

> 2. The function presently called svn_client_revert_list
> doesn't report nonexistent-path errors. (Maybe it should
> do, but the only caller is the commandline client, which
> ignores them.) It feels wrong to expose *no* version of
> "revert" that just reports an error when a path doesn't
> exist.

As Philip said, that could be taken care of by the notification
callback.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 1 05:00:47 2003

This is an archived mail posted to the Subversion Dev mailing list.